fix: Moved GRPC services over to use PBJ generated ones #1155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jasper Potts <1466205+jasperpotts@users.noreply.github.com>
| import edu.umd.cs.findbugs.annotations.NonNull; | ||
| import java.util.Arrays; | ||
| import java.util.List; | ||
| import org.hiero.block.api.BlockAccessServiceInterface; | ||
| import org.hiero.block.api.BlockRequest; | ||
| import org.hiero.block.api.BlockResponse; | ||
| import org.hiero.block.api.BlockResponse.Code; | ||
| // PBJ doesn't generate GRPC stubs for some reason, also the proto file is broken when PBJ compiles it... |
There was a problem hiding this comment.
Might want to remove this comment as well.
| this.openSessions = new ConcurrentSkipListMap<>(); | ||
| virtualThreadExecutor = context.threadPoolManager().getVirtualThreadExecutor(null); | ||
| virtualThreadExecutor = context.threadPoolManager().getVirtualThreadExecutor("SubscribeBlockStreamHandler"); |
There was a problem hiding this comment.
This was null on purpose, so we don't create unique executors for every single handler.
By setting the name, you get a new executor service for each handler, and all of the created threads have the exact same thread name (which doesn't really help).
jsync-swirlds
approved these changes
May 16, 2025
AlfredoG87
approved these changes
May 16, 2025
There was a problem hiding this comment.
LGTM, other than the comments leaved by @jsync-swirlds
Also spotless is complaining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Stops exporting protoc to anything other than simulator and suites
Related Issue(s)
Fixes #1088